Prevent async ClusterPipeline instances from becoming "false-y" in ca… #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3068 +/- ##
==========================================
- Coverage 91.16% 91.16% -0.01%
==========================================
Files 127 127
Lines 32855 32854 -1
==========================================
- Hits 29953 29952 -1
Misses 2902 2902 ☔ View full report in Codecov by Sentry. |
…se of empty command stack
|
CI appears to be flakey - I believe these random failures are unrelated to the PR. |
dvora-h
approved these changes
Dec 11, 2023
gerzse
pushed a commit
to gerzse/redis-py
that referenced
this pull request
Jul 11, 2024
…se of empty command stack (redis#3068)
gerzse
pushed a commit
that referenced
this pull request
Jul 11, 2024
…se of empty command stack (#3068)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…se of empty command stack
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Closes #3061